henrypp / simplewall

Simple tool to configure Windows Filtering Platform (WFP) which can configure network activity on your computer.
GNU General Public License v3.0
5.8k stars 468 forks source link

[Bug] Protocol 4 is mislabeled as "IPv4" #1781

Closed ghost closed 2 months ago

ghost commented 2 months ago

Checklist

App version

3.8.0

Windows version

Windows 11 19045

Steps to reproduce

  1. Start adding a new rule
  2. Look at Protocols
  3. Notice Protocol 4 is labeled as "IPv4"

Expected behavior

No response

Actual behavior

Protocol 4 is mislabeled as "IPv4" in SimpleWall, but Protocol 4 is actually "IP-in-IP" encapsulation https://en.wikipedia.org/wiki/List_of_IP_protocol_numbers . It does not filter any IPv4 TCP and/or IPv4 UDP packets. Protocol should simply renamed from "IPv4" to "IP-in-IP".

Logs

No response

henrypp commented 2 months ago

sshot-003

dont understand ur language and where is a problem

ghost commented 2 months ago

That's Microsoft's labeling for internal code, but it is misleading to label it simply as "IPv4". Protocol 4 is a defined network protocol and the correct label for it is "IP-in-IP" or "IPIP" - https://www.rfc-editor.org/rfc/rfc1853 .