henrypp / simplewall

Simple tool to configure Windows Filtering Platform (WFP) which can configure network activity on your computer.
GNU General Public License v3.0
5.8k stars 468 forks source link

[Feature] Close rules window on Escape key #1798

Closed eugenesvk closed 1 month ago

eugenesvk commented 1 month ago

Checklist

App version

3.8.2

Problem you are trying to solve

Conveniently closing rules' window with a keyboard

Suggested solution

Make Escape fulfill it's expected role and closed the modal window with a rule

(interestingly enough, it can close the main app's window, but not the "smaller" rules window)

Screenshots / Drawings / Technical details

No response

henrypp commented 1 month ago

every window already have close on escape

eugenesvk commented 1 month ago

No they don't, check out this video - you can't close the rule modal with Escape right away. Though during more testing I've discovered that Escape starts to work once you alt-tab (or in the video click on the desktop then click on the rule window)

https://github.com/henrypp/simplewall/assets/12956286/bbcb4f50-6e2e-4b75-a3ad-88fc5798d7b7

henrypp commented 1 month ago

it because it required to select any control, press to any input

eugenesvk commented 1 month ago

And it shouldn't, Escape should close the active modal window regardless of any interaction just like it does for the main window or other apps. Why are these modals so special and hard to quit?

By the way, it doesn't work on "any control", if you click on tabs, they apparently don't count as "controls", so Escape doesn't work, which is very weird