search

henrypp / simplewall

Simple tool to configure Windows Filtering Platform (WFP) which can configure network activity on your computer.
GNU General Public License v3.0
6.08k stars 481 forks source link

Semicolons in exe file paths cause invalid entries when exporting and importing custom rules #462

Closed Robot1me closed 5 years ago

Robot1me commented 5 years ago

How to verify this bug:

  1. Add a program to Simplewall that has a semicolon somewhere in its file path.
  2. Create a custom rule. Select multiple programs, including the one with the semicolon.
  3. Export rules_custom.xml
  4. Import rules_custom.xml
  5. The application splits the affected program paths earlier than expected due to the semicolon in the file path, which creates trash entries. Applications that don't have any semicolon in their path or name are unaffected and those paths are parsed correctly.

Suggestion: Perhaps it's a good idea to switch to a pipe ( | ) to separate paths in rules? Because that is for sure an illegal path character in Windows file paths.

Thanks for your time.

henrypp commented 5 years ago

ok, fixed. replaced ; with |