henrytao-me / smooth-app-bar-layout

Smooth version of Google Support Design AppBarLayout
Apache License 2.0
1.77k stars 240 forks source link

SmoothAppBarLayout with wrap_content doesn't work for me #200

Closed AnthonyKoueik closed 7 years ago

AnthonyKoueik commented 7 years ago

hello

i am putting an ImageView inside CollapsingToolbarLayout and i want to wrap_content the image size but in all your examples you have a predefined app_bar_height and you add it to paddingTop in your NestedScollView layout.

how can i make the wrap_content work ?

henrytao-me commented 7 years ago

Can you post your full layout here?

AnthonyKoueik commented 7 years ago
<?xml version="1.0" encoding="utf-8"?>
<android.support.design.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:fitsSystemWindows="true">

    <me.henrytao.smoothappbarlayout.widget.NestedScrollView
        android:id="@+id/nested_scroll_view"
        android:layout_width="match_parent"
        android:layout_height="match_parent">

        <LinearLayout
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:orientation="vertical"
            android:paddingLeft="16dp"
            android:paddingRight="16dp"
            **android:paddingTop="@dimen/app_bar_heightight"**> herer is the problem, what i can i do here?

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:layout_marginBottom="16dp"
                android:layout_marginTop="16dp"
                android:text="@string/app_name" />

            <TextView
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:layout_marginBottom="16dp"
                android:text="@string/text_long" />
        </LinearLayout>
    </me.henrytao.smoothappbarlayout.widget.NestedScrollView>

    <me.henrytao.smoothappbarlayout.SmoothAppBarLayout
        android:id="@+id/smooth_app_bar_layout"
        android:layout_width="match_parent"
        **android:layout_height="wrap_content"**
        android:fitsSystemWindows="true">

        <android.support.design.widget.CollapsingToolbarLayout
            android:id="@+id/collapsing_toolbar_layout"
            android:layout_width="match_parent"
            **android:layout_height="wrap_content"**
            android:fitsSystemWindows="true"
            app:contentScrim="?attr/colorPrimary"
            app:layout_scrollFlags="scroll|exitUntilCollapsed">

            <ImageView
                android:id="@+id/backdrop"
                android:layout_width="match_parent"
                **android:layout_height="wrap_content"**
                android:fitsSystemWindows="true"
                android:scaleType="centerCrop"
                android:src="@drawable/cover"
                app:layout_collapseMode="parallax" />

            <android.support.v7.widget.Toolbar
                android:id="@+id/toolbar"
                android:layout_width="match_parent"
                android:layout_height="?attr/actionBarSize"
                app:layout_collapseMode="pin"
                app:popupTheme="@style/ThemeOverlay.AppCompat.Light" />
        </android.support.design.widget.CollapsingToolbarLayout>
    </me.henrytao.smoothappbarlayout.SmoothAppBarLayout>
</android.support.design.widget.CoordinatorLayout>
henrytao-me commented 7 years ago

Hi @AnthonyKoueik,

You have to set layout_height for ImageView and set paddingTop for NestedScrollView in order to make it work. Here is an example.

<android.support.design.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
  xmlns:app="http://schemas.android.com/apk/res-auto"
  android:layout_width="match_parent"
  android:layout_height="match_parent"
  android:fitsSystemWindows="true">

  <me.henrytao.smoothappbarlayout.widget.NestedScrollView
    android:id="@+id/nested_scroll_view"
    android:layout_width="match_parent"
    android:layout_height="match_parent">

    <LinearLayout
      android:layout_width="match_parent"
      android:layout_height="wrap_content"
      android:orientation="vertical"
      android:paddingLeft="16dp"
      android:paddingRight="16dp"
      android:paddingTop="@dimen/app_bar_height">

      <TextView
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_marginBottom="16dp"
        android:layout_marginTop="16dp"
        android:text="@string/app_name" />

      <TextView
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_marginBottom="16dp"
        android:text="@string/text_long" />
    </LinearLayout>
  </me.henrytao.smoothappbarlayout.widget.NestedScrollView>

  <me.henrytao.smoothappbarlayout.SmoothAppBarLayout
    android:id="@+id/smooth_app_bar_layout"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:fitsSystemWindows="true">

    <android.support.design.widget.CollapsingToolbarLayout
      android:id="@+id/collapsing_toolbar_layout"
      android:layout_width="match_parent"
      android:layout_height="wrap_content"
      android:fitsSystemWindows="true"
      app:contentScrim="?attr/colorPrimary"
      app:layout_scrollFlags="scroll|exitUntilCollapsed">

      <ImageView
        android:id="@+id/backdrop"
        android:layout_width="match_parent"
        android:layout_height="@dimen/app_bar_height"
        android:fitsSystemWindows="true"
        android:scaleType="centerCrop"
        android:src="@drawable/cover"
        app:layout_collapseMode="parallax" />

      <android.support.v7.widget.Toolbar
        android:id="@+id/toolbar"
        android:layout_width="match_parent"
        android:layout_height="?attr/actionBarSize"
        app:layout_collapseMode="pin"
        app:popupTheme="@style/ThemeOverlay.AppCompat.Light" />
    </android.support.design.widget.CollapsingToolbarLayout>
  </me.henrytao.smoothappbarlayout.SmoothAppBarLayout>
</android.support.design.widget.CoordinatorLayout>
AnthonyKoueik commented 7 years ago

yes that's what i wanted to solve , i don't want to put a heightfor the ImageView, instead i want it height's as wrap_content because i dont want to scale it and i want to give it actual height .

henrytao-me commented 7 years ago

Dynamic height may not work properly with SmoothAppBarLayout. Do you know image ratio a head of time? If yes, I prefer to calculate image height base on ratio in java code.

AnthonyKoueik commented 7 years ago

mmmm alright, i wanted to prevent it because i didn't want to calculat it in Java. thank you

henrytao-me commented 7 years ago

I am sorry to hear that. I can't help you in this case.

AnthonyKoueik commented 7 years ago

no problem buddy, nice work btw