search

henrytao-me / smooth-app-bar-layout

Smooth version of Google Support Design AppBarLayout
Apache License 2.0
1.77k stars 240 forks source link

deprecated after 26.0.0? #208

Closed kassim closed 7 years ago

kassim commented 7 years ago

I just switched to the support library 26.0.0 (which was causing the appbar from this library to misbehave pretty badly) and after switching out the SmoothAppBarLayout component for the official AppBarLayout, the intended "smoothness" previously provided from this library was there

I could be mistaken, but it seems like the error of the support library that this project was intended to fix, may indeed now be fixed

henrytao-me commented 7 years ago

Thanks for your report. I will check it later. But if it works as you mentioned, it is awesome. We are all waiting for the fix for a long long time.

henrytao-me commented 7 years ago

Hi @kassim, I confirm that the issue this library intending to fix is fixed in support library 26.0.0. Bravo support library team.

kassim commented 7 years ago

bravo to you, creating a working implementation that Google couldn't, at least up until now

thanks for your great work

roman-ku commented 7 years ago

@henrytao-me Can you add a note to the github page? That it's deprecated because the issue has been finally addressed by the support library.

Btw thanks for the great library! 👍

roman-ku commented 7 years ago

Also I couldn't find the fix documented here: https://developer.android.com/topic/libraries/support-library/revisions.html

henrytao-me commented 7 years ago

@roman-ku I added this to README already. [DEPRECATED] Use support design 26.0.0 or above instead. Even the fix isn't documented but it is there. I have tested it.

roman-ku commented 7 years ago

I wasn't sure why the library was deprecated, adding a little something about it being fixed wouldn't hurt.

henrytao-me commented 7 years ago

@roman-ku I updated the README to make it more clear. All the best.

roman-ku commented 7 years ago

Thanks!