search

henrythasler / Leaflet.Geodesic

Add-on to draw geodesic lines with leaflet
GNU General Public License v3.0
156 stars 27 forks source link

required build artefacts #82

Closed henrythasler closed 2 years ago

henrythasler commented 2 years ago

The build pipeline currently generates these files: image

The CDN statistics show that almost all downloads are just the umd.min.js-file: image

Questions:

  1. Do I need to continue to provide the other (esm, non-minified) files? Let me know your opinion.
  2. How can I properly test these generated files?
matafokka commented 2 years ago

Do I need to continue to provide the other (esm, non-minified) files? Let me know your opinion.

I'd suggest keeping everything as it is. Who knows what might come in handy?

By the way, it'd be great to add command like build:debug that'll build unminified UMD file for testing in browser. This will reduce compilation time. Caching also will help.

How can I properly test these generated files?

You're not using any polyfills, browser-specific hacks or stuff like that. Basically, you get what you write, no need for other tests.

Jest should internally compile TS to JS, unless it uses deno, so your bundle is already tested.

henrythasler commented 2 years ago

Thanks for the feedback. I just cleaned up the build-scripts a bit (now platform independent) but left the resulting artifacts untouched. There is now also a build:dev command you could adapt for your purposes.

matafokka commented 2 years ago

Cool, thanks!