search

henrytseng / dataobject-parser

A nodejs module designed to parse an Object hash transposing between dot-notation and a structured heirarchy of Objects/Arrays.
MIT License
31 stars 18 forks source link

Please update to latest lodash #8

Closed blord-fullscreen closed 7 years ago

blord-fullscreen commented 7 years ago

For browser apps, size matters. For webpack and similar workflows, requiring ancient versions of utility libraries runs a risk of code duplication in bundles. lodash is currently at 4.17.4. You're specifying "~2.4.1".

While I'm here wishing, could you also please require only the utility functions that you're actually using, and not the whole library? At a glance, it looks like you're only calling isArray, isObject, and isUndefined. Again, it's lighter on the wire.

Thanks for maintaining this!

henrytseng commented 7 years ago

Sorry this is an ancient project. I think it'd be a good idea to not use those.

blord-fullscreen commented 7 years ago

I'm not sure what you mean. It was version-bumped just three months ago.

henrytseng commented 7 years ago

The code was written 3 years ago, not used internally anymore. I'll update it to remove lodash--that sounds reasonable. Hope it continues to be helpful to you if you need it.

blord-fullscreen commented 7 years ago

Yeah, I'm using it. Thanks!