search

henryw374 / time-literals

Clojure(Script) tagged literals for jsr-310 ( java.time) entities
MIT License
65 stars 10 forks source link

add transit encodings #2

Open henryw374 opened 5 years ago

jdf-id-au commented 5 years ago

Here's a sketch which should work. Sorry don't have time to wrap up into PR.

jjttjj commented 4 years ago

@jdf-id-au your sketch has been working good for me. I have forked your gist to make a couple small changes and add a deps.edn, so that it can be used in a project via the following git dep:

  transit-connection {:git/url "https://gist.github.com/jjttjj/6bc0b62ef1dbf29c1c69ea22f8eb7f55"
                      :sha "2345014effd1ce7089d2b847808d4bbcf2c38a3b"}

I could put together a PR for this if desired.

henryw374 commented 4 years ago

Cool, I would certainly accept a PR, but clearly this works as is, so no great hurry

Quantisan commented 3 years ago

I released a separate library to do this. https://github.com/Motiva-AI/pipeline-transit/blob/master/src/pipeline_transit/core.clj

I'm not sure if this feature should go into this library though. Not everyone needs to use transit with time-literals and adding it would require roping in the transit-clj and cljs libraries for this use case. Thus bloating this library.

henryw374 commented 3 years ago

I released a separate library to do this. https://github.com/Motiva-AI/pipeline-transit/blob/master/src/pipeline_transit/core.clj

I'm not sure if this feature should go into this library though. Not everyone needs to use transit with time-literals and adding it would require roping in the transit-clj and cljs libraries for this use case. Thus bloating this library.

Thanks. I agree wrt dependencies.

I think what I'll do is link from the README and close this issue.

I notice the file you link to is just clj, rather than cljc as the gist further up was.

awb99 commented 1 year ago

Here is an implementation that is working for myself (it works with cljc): https://github.com/pink-gorilla/modular/blob/main/src/modular/encoding/time2.cljc