henrywhitaker3 / Speedtest-Tracker

Continuously track your internet speed
GNU General Public License v3.0
1.49k stars 122 forks source link

[Feature Request] Thoughts on moving off of the Ookla speedtest-cli on to a different provider? #590

Open sOblivionsCall opened 3 years ago

sOblivionsCall commented 3 years ago

Describe the feature Thoughts on moving off of the Ookla speedtest-cli on to a different provider?

e.g:

Additional context I haven't gone through how your code deals with the values and commands executed and returned from the CLI and make no claims at all to know anything about PHP but this may be a solution to:

Happy to assist with anything container side if you are interested in exploring using a different cli for the speedtest metrics.

henrywhitaker3 commented 3 years ago

Have mentioned it in a different ticket that I've laid the groundwork for adding different providers in, but haven't had the time to actually implement it yet. Was thinking fast.com (.net?) for the first one

sOblivionsCall commented 3 years ago

@henrywhitaker3 I would always be wary of integrating anything from Netflix in my code :rofl: that said fast.com is a well known and used provider, can you link the ticket you have discussed this in when you have a chance? I would like to be a part of the discussion and am wondering if you are planning to pull in a cli package for each individual provider and/or create api calls for each provider depending on selection etc.

henrywhitaker3 commented 3 years ago

Can't remember which one it's in tbh, but was just one comment about it

Yeah, would probably set it with an env var to choose between providers