search

henrywhitaker3 / Speedtest-Tracker

Continuously track your internet speed
GNU General Public License v3.0
1.54k stars 121 forks source link

[BUG] Impossible to change timeframe window #680

Open lukou31 opened 3 years ago

lukou31 commented 3 years ago

Describe the bug No effect when changing "Show results for the last" to a different value from 7. Working fine before the upgrade.

Context Version : 1.12.0 Synology - DSM7

brommeltje commented 3 years ago

Same issue on debian 10

makidoll commented 3 years ago

Same here, just running latest Docker image on x86_64. Will probably revert until fixed.

masterwishx commented 3 years ago

Same issue in docker on Unraid (linux/amd64)

jaxjexjox commented 3 years ago

Ok so it's not just me! Damnit. I've logged a duplicate of this. Sorry.

jaxjexjox commented 3 years ago

Dupe here, sorry. https://github.com/henrywhitaker3/Speedtest-Tracker/issues/682

jaxjexjox commented 3 years ago

Does anyone know how to pull an old version, this is occurring at the WORST possible time for me! I need to provide data for a line fault to my ISP :(

I only see 4 versions here?! https://hub.docker.com/r/henrywhitaker3/speedtest-tracker/tags?page=1&ordering=-last_updated

Do I just pull dev?

makidoll commented 3 years ago

Does anyone know how to pull an old version, this is occurring at the WORST possible time for me! I need to provide data for a line fault to my ISP :(

I only see 4 versions here?! https://hub.docker.com/r/henrywhitaker3/speedtest-tracker/tags?page=1&ordering=-last_updated

Do I just pull dev?

The dev doesn't upload each individual version on Docker hub for some reason... But I looked through my docker images and used the image id of the previously downloaded version

jaxjexjox commented 3 years ago

I have pulled the 4 month old 'dev' release and it has fixed nothing, the image appears to be identical somehow. I (thought) I had a rough idea on how to work with docker, alas, perhaps this is not the case.

Anyone got any idea, how I can get back to the old edition, I need to convince my ISP I have a line fault and I'd really like to be able to produce some nice graphs.

jaxjexjox commented 3 years ago

Does anyone know how to pull an old version, this is occurring at the WORST possible time for me! I need to provide data for a line fault to my ISP :( I only see 4 versions here?! https://hub.docker.com/r/henrywhitaker3/speedtest-tracker/tags?page=1&ordering=-last_updated Do I just pull dev?

The dev doesn't upload each individual version on Docker hub for some reason... But I looked through my docker images and used the image id of the previously downloaded version

I'm an idiot who cleans up disk space by purging and pruning old stuff! :(

EDIT Ok I apologise I've just re-read your post and it's clear, they're not available for me to snatch again (honestly, I didn't know this was even possible!)

Any tips how I can spin up an old one?

makidoll commented 3 years ago

I've uploaded a tar.gz of the image on my server here: https://files.cutelab.space/f/ebb317bf98074fe78340/ Once loaded, you can use it with image id: 25b86b3d603a

I don't know how to prove this is the official release... I just want to help out. The owner of this project should really push the version tag and then latest tag to Docker hub.

wget -O speedtest-tracker-1.10.4.tar.gz "https://files.cutelab.space/f/ebb317bf98074fe78340/?dl=1"
docker load -i speedtest-tracker-1.10.4.tar.gz
makidoll commented 3 years ago

You might have to backup your data in the webui settings first, then remove your data volume, start the container fresh and import your data back in. It will break if you try to downgrade.

jaxjexjox commented 3 years ago

I <3 linux, open source stuff, docker and you!

Magic, just wonderful. Thanks for the docker load command, I sat here in my windows mindset wondering how to extract the tar, copy the files into a folder full of images to work with. You probably saved me hours.

Did indeed have to backup data, been a bit of a mess but I have graphs now to show my ISP my line is stuffed. Thanks again. MUST stop being in the habit of purging and pruning behind me so regularly.

makidoll commented 3 years ago

I'm really glad I could help! I prune things pretty often too and I'm not afraid of going cutting edge. But this project definitely needs a Docker overhaul. It's not done correctly. Not only do versions not get released, but the owner copies the root of the main branch into a separate branch in a weird way, compile on their machine and then build the image.

I might send in a pr so you can docker build and it will compile and put everything together like it should. Then you can make fresh builds of any version without understanding php or npm.

jaxjexjox commented 3 years ago

They probably don't know any better (I know I don't) so any help for the original developer is probably quite helpful.

The only reason I'm using this, is because this guy broke this one. https://github.com/roest01/docker-speedtest-analyser/issues/75

It need a fork or some such which updates a file. https://github.com/roest01/docker-speedtest-analyser/pull/82

Sn00zEZA commented 3 years ago

Also having this issue

henrywhitaker3 commented 3 years ago

Building a fix for this now lads. Was an issue with the refresh happening before the state was change, if u update the number of days again it has the right value the second time

henrywhitaker3 commented 3 years ago

Right turns out there was another issue, but have pushed a new dev and dev-arm image - see if it sorts it for you and will merge to master

db77x commented 3 years ago

dev build 12.1 working now for down/upload and ping. But not for successful/faild graph. Testest with various days 30, 180, 360 etc. Maybe you can fix it also @henrywhitaker3 ?

burtaverde commented 3 years ago

can confirm, same results as db77x. Also i might be wrong, but if i remember correctly, it used to show the timeline on all graphs and currently they're empty on the bottom

masterwishx commented 3 years ago

confirm (dev) working Download,Upload,Ping Graphs on Unraid (linux/amd64) but not the Failure graph

masterwishx commented 3 years ago

v 1.12.2 dev all graphs is working now in Unraid (linux/amd64)

jaxjexjox commented 3 years ago

I take it this one isn't published as official yet, right? (where can I check? Sorry for hassling!)

jaxjexjox commented 3 years ago

Can I just confirm, this is still broken, in both latest and dev docker builds, right? (It's still dead for me)

tuckshoprn commented 3 years ago

It is working for me on the dev branch. Running in docker on Linux server.

Sent from my iPhone

On Sep 18, 2021, at 10:53, jaxjexjox @.***> wrote:

 Can I just confirm, this is still broken, in both latest and dev docker builds, right? (It's still dead for me)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

jaxjexjox commented 3 years ago

Ok that's a bit odd, perhaps I need to nuke my data directory. I also notice this one sure chews some disk space.

jaxjexjox commented 3 years ago

Yeah looks like I needed a fresh data directory, no biggie, I could do with a fresh folder anyhow. Thanks for hard work henry.

tuckshoprn commented 3 years ago

Mine is around 337MB which includes 2.7MB .db file.

Sent from my iPhone

On Sep 18, 2021, at 11:11, jaxjexjox @.***> wrote:

 Yeah looks like I needed a fresh data directory, no biggie, I could do with a fresh folder anyhow. Thanks for hard work henry.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

jaxjexjox commented 3 years ago

I mean look, disk space is cheap, I'll get over it, but I'll say the CSV file from other apps is in the kilobytes, I'm not sure why so much is on the disk but no big deal, at least this works! Unlike roests one.

Sn00zEZA commented 3 years ago

When will this bug fix merge with latest for docker?