henryzt / Rhythm-Plus-Music-Game

Community-based vertical scrolling rhythm game (VSRG) made with Vue.js and canvas (WIP)
https://rhythm-plus.com
GNU General Public License v3.0
166 stars 27 forks source link

Video stops playing from a removed ad. #255

Closed UltraFatBoi closed 3 months ago

UltraFatBoi commented 4 months ago

On, Microsoft Edge, the video stops playing after an ad trys to play and it just says "Ad removed." and then the video doesn't play ever again, resulting in the song not working. Any fixes? Screenshot 2024-03-02 211830

henryzt commented 4 months ago

Hi, thanks for the report! Could you send the link to the sheet where you experienced this? I have tried serveral but I can't find a Youtube embed that actually plays a mid-roll ad for me to test this.

UltraFatBoi commented 3 months ago

https://rhythm-plus.com/game/FDWCmB6TQMPNAm1VJcbohr idk if this is it but here

On Sun, Mar 3, 2024, 10:58 AM Henry @.***> wrote:

Hi, thanks for the report! Could you send the link to the sheet where you experienced this? I have tried serveral but I can't find a Youtube embed that actually plays a mid-roll ad for me to test this.

— Reply to this email directly, view it on GitHub https://github.com/henryzt/Rhythm-Plus-Music-Game/issues/255#issuecomment-1975205510, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBEGSCF42MBBRKNS4VXBMU3YWNCEFAVCNFSM6AAAAABEDSF2R2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGIYDKNJRGA . You are receiving this because you authored the thread.Message ID: @.***>

henryzt commented 3 months ago

Sadly I still can't see any ads no matter the browser. Since I have no control of the ad and there are no events from Youtube or any method to load them for testing, I'm guessing the game cannot correctly handle them as of now.

Do you always see ads when you play this map, and does other maps show ads as well? If you change a browser, will it behave differently?

UltraFatBoi commented 3 months ago

Yes it happens on other maps and I was using Microsoft Edge I'll just close this issue and play a different rhythm game like GPOP or somthing.

UltraFatBoi commented 3 months ago

I closed it I'll just play GPOP for now.

henryzt commented 3 months ago

You can try to toggle 'Sync Plays to YouTube' option in the settings which could fix the issue. Additionally, we have planned to add a mode where the Youtube player is on the side similar to GPOP in v2. Could you please check if the same video displays ads when played in GPOP?

I'd love to disscuss the issue further, if you prefer, feel free to find me on discord @format.z

Thanks again :)