henselman-petrusek / Eirene.jl

Julia library for homological persistence
Other
117 stars 21 forks source link

Update wasserstein_distance #17

Closed yossibokorbleile closed 5 years ago

yossibokorbleile commented 5 years ago

Have fixed an error about array dimensions for broadcasting in "dist_mat" used for "wasserstein_distance".

henselman-petrusek commented 5 years ago

Thanks for the pull request! I'm getting an error when I try loading the new module. Can you reproduce?

julia> using Eirene
[ Info: Recompiling stale cache file /Users/gh10/.julia/compiled/v1.2/Eirene/mCiG1.ji for Eirene [9c0f25c4-2ca1-5870-89f6-52640788da1d]
WARNING: Method definition savehtml(IO, PlotlyBase.Plot{TT} where TT<:PlotlyBase.AbstractTrace) in module PlotlyBase at /Users/gh10/.julia/packages/PlotlyBase/80KwD/src/output.jl:40 overwritten in module PlotlyJS at /Users/gh10/.julia/packages/PlotlyJS/b9Efu/src/display.jl:334.
  ** incremental compilation may be fatally broken for this module **

WARNING: Method definition savehtml(PlotlyBase.Plot{TT} where TT<:PlotlyBase.AbstractTrace, AbstractString) in module PlotlyBase at /Users/gh10/.julia/packages/PlotlyBase/80KwD/src/output.jl:52 overwritten in module PlotlyJS at /Users/gh10/.julia/packages/PlotlyJS/b9Efu/src/display.jl:361.
  ** incremental compilation may be fatally broken for this module **

ERROR: LoadError: LoadError: syntax: incomplete: "function" at /Users/gh10/tutorial/dev/Eirene/src/wasserstein_distances.jl:93 requires end
Stacktrace:
 [1] top-level scope at /Users/gh10/tutorial/dev/Eirene/src/wasserstein_distances.jl:93
 [2] include at ./boot.jl:328 [inlined]
 [3] include_relative(::Module, ::String) at ./loading.jl:1094
 [4] include at ./Base.jl:31 [inlined]
 [5] include(::String) at /Users/gh10/tutorial/dev/Eirene/src/Eirene.jl:29
 [6] top-level scope at /Users/gh10/tutorial/dev/Eirene/src/Eirene.jl:9298
 [7] include at ./boot.jl:328 [inlined]
 [8] include_relative(::Module, ::String) at ./loading.jl:1094
 [9] include(::Module, ::String) at ./Base.jl:31
 [10] top-level scope at none:2
 [11] eval at ./boot.jl:330 [inlined]
 [12] eval(::Expr) at ./client.jl:432
 [13] top-level scope at ./none:3
in expression starting at /Users/gh10/tutorial/dev/Eirene/src/wasserstein_distances.jl:93
in expression starting at /Users/gh10/tutorial/dev/Eirene/src/Eirene.jl:9298
ERROR: Failed to precompile Eirene [9c0f25c4-2ca1-5870-89f6-52640788da1d] to /Users/gh10/.julia/compiled/v1.2/Eirene/mCiG1.ji.
Stacktrace:
 [1] error(::String) at ./error.jl:33
 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1253
 [3] _require(::Base.PkgId) at ./loading.jl:1013
 [4] require(::Base.PkgId) at ./loading.jl:911
 [5] require(::Module, ::Symbol) at ./loading.jl:906
yossibokorbleile commented 5 years ago

EDIT AEDT 15/11/2019 1352: After looking at this fully awake, I have found the actual error introduced in the changes I made. I will fix them and then create a new pull request. 0400AEDT me did't fully read the message, probably something about lack of coffee.

Yes I can. What Julia version are you using? That error occurred before I changed the Wasserstein distance code.

On 16 Nov 2019, at 04:58, Gregory Henselman-Petrusek notifications@github.com wrote:

 Thanks for the pull request! I'm getting an error when I try loading the new module. Can you reproduce?

julia> using Eirene [ Info: Recompiling stale cache file /Users/gh10/.julia/compiled/v1.2/Eirene/mCiG1.ji for Eirene [9c0f25c4-2ca1-5870-89f6-52640788da1d] WARNING: Method definition savehtml(IO, PlotlyBase.Plot{TT} where TT<:PlotlyBase.AbstractTrace) in module PlotlyBase at /Users/gh10/.julia/packages/PlotlyBase/80KwD/src/output.jl:40 overwritten in module PlotlyJS at /Users/gh10/.julia/packages/PlotlyJS/b9Efu/src/display.jl:334. incremental compilation may be fatally broken for this module

WARNING: Method definition savehtml(PlotlyBase.Plot{TT} where TT<:PlotlyBase.AbstractTrace, AbstractString) in module PlotlyBase at /Users/gh10/.julia/packages/PlotlyBase/80KwD/src/output.jl:52 overwritten in module PlotlyJS at /Users/gh10/.julia/packages/PlotlyJS/b9Efu/src/display.jl:361. incremental compilation may be fatally broken for this module

ERROR: LoadError: LoadError: syntax: incomplete: "function" at /Users/gh10/tutorial/dev/Eirene/src/wasserstein_distances.jl:93 requires end Stacktrace: [1] top-level scope at /Users/gh10/tutorial/dev/Eirene/src/wasserstein_distances.jl:93 [2] include at ./boot.jl:328 [inlined] [3] include_relative(::Module, ::String) at ./loading.jl:1094 [4] include at ./Base.jl:31 [inlined] [5] include(::String) at /Users/gh10/tutorial/dev/Eirene/src/Eirene.jl:29 [6] top-level scope at /Users/gh10/tutorial/dev/Eirene/src/Eirene.jl:9298 [7] include at ./boot.jl:328 [inlined] [8] include_relative(::Module, ::String) at ./loading.jl:1094 [9] include(::Module, ::String) at ./Base.jl:31 [10] top-level scope at none:2 [11] eval at ./boot.jl:330 [inlined] [12] eval(::Expr) at ./client.jl:432 [13] top-level scope at ./none:3 in expression starting at /Users/gh10/tutorial/dev/Eirene/src/wasserstein_distances.jl:93 in expression starting at /Users/gh10/tutorial/dev/Eirene/src/Eirene.jl:9298 ERROR: Failed to precompile Eirene [9c0f25c4-2ca1-5870-89f6-52640788da1d] to /Users/gh10/.julia/compiled/v1.2/Eirene/mCiG1.ji. Stacktrace: [1] error(::String) at ./error.jl:33 [2] compilecache(::Base.PkgId, ::String) at ./loading.jl:1253 [3] _require(::Base.PkgId) at ./loading.jl:1013 [4] require(::Base.PkgId) at ./loading.jl:911 [5] require(::Module, ::Symbol) at ./loading.jl:906 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.