hensm / fx_cast

Chromecast Web Sender SDK implementation for Firefox
https://hensm.github.io/fx_cast/
MIT License
1.87k stars 63 forks source link

No Sites Apps are ever Found on Winx64 #147

Closed BuzzfeedBlue closed 4 years ago

BuzzfeedBlue commented 4 years ago

Every website has "this site's app (not found)", regardless of site, and whether it is added to the whitelists (by name or by ) or not. Unable to get anything to cast on newest version, despite it recognizing my chromecast on the same wifi network and the bridge reportedly being up.

hensm commented 4 years ago

This is a regression from 0.0.7? Can you provide any logs (info here)?

BuzzfeedBlue commented 4 years ago

I know how to open the page elements but I dont actually know what you are requesting on my end. I dont know what info you need. Ill attach the console readout for now and provide more when you get back to me image

hensm commented 4 years ago

Is it a regression i.e. did it work in the previous version? If you've only used the latest version, ignore that.

There are a few different consoles that provide logs from different places. The web console (which you provided) will show errors from the site and extension content scripts, the browser console will show errors from the bridge, and the extension console will show errors from the extension background script. The links in CONTRIBUTING have instructions on where to find them. Not especially intuitive, I know.

Perhaps verify the user agent string is being set correctly (copy and paste navigator.userAgent into the web console). Result should be:

"Mozilla/5.0 (Windows NT 10.0; Win64; x64) Chrome/80.0.3987.87 Gecko/20100101 Firefox/72.0"

It may also be helpful to provide your current whitelist, you can copy and paste from the raw view in the options page.

This is what the web console looks like for YouTube when it's working: logs

These issues are just extremely difficult to debug if I can't reproduce them, so as much information as possible is appreciated.

BuzzfeedBlue commented 4 years ago

The string you gave is not coming up the same and the addon says when I try to use it that it sees my chromecast, and that the bridge is connected and has a green check mark, but from the logs that doesnt seem to be the case. This is the first time I've used any of this so regression shouldnt be an issue, and the whitelist for testing was just https://www.youtube.com/* or image image image

hensm commented 4 years ago

Weird, does the options page have the full bridge details like this? info

It looks like the request to the bridge to get info is failing and timing out. I do that before notifying the site that it can start casting, so when that fails, the site never registers its app and it shows up as not found. I'll take a better look at this later, but that's useful info, thanks!

BuzzfeedBlue commented 4 years ago

Yeah no prob. Thanks for working with me and for making such a useful tool :) Im glad any info I can provide will be useful in getting this whole thing further out of beta

edit: yes my options page looks like this, didnt see that was a question at the top lol image

hensm commented 4 years ago

I think it's just a race condition with the timeout. Can you test this build?

https://extensionworkshop.com/documentation/develop/temporary-installation-in-firefox/ Extension archive: fx_cast-0.1.0.zip

BuzzfeedBlue commented 4 years ago

That build is at least able to allow me to hit cast, and the buttons show up on youtube and google play music's site. However youtube, when I try to play a video, gets stuck and no media ever plays. I am unable to click the play button, and my tv says ready to cast, go on your device and play something.

Google play music is able to play a song, but it will quickly cycle through the entire album, and on the last song since it cant go any further will actually play on the tv. However, I cant control the media by pausing or changing the volume or going to a different song.

hensm commented 4 years ago

Nice, I think this issue is fixed then. If you open another for those bugs and provide some logs (if there are any), I'll take a look at them.