hensm / fx_cast

Chromecast Web Sender SDK implementation for Firefox
https://hensm.github.io/fx_cast/
MIT License
1.87k stars 63 forks source link

Bridge in daemon mode not terminating when shutting down the pc on linux #230

Closed luca-demma closed 1 year ago

luca-demma commented 2 years ago

PopOS 22.04 (Ubuntu based) Bridge version: v0.2.0

Description When using the bridge in daemon mode if I shutdown the pc the daemon doesn't terminate getting the "A stop job is running for service fx_cast daemon"

This the configuration file of the daemon I'm using:

[Unit]
Description=fx_cast daemon

[Service]
User=fx_cast
ExecStart=/opt/fx_cast/fx_cast_bridge -d
Restart=always

[Install]
WantedBy=multi-user.target

Steps to reproduce

  1. Set the bridge in daemon mode on linux as service
  2. Shutdown or restart the pc (if the error is not shown press canc while shutting down)

Expected behaviour Shutting down the pc stopping the daemon

hensm commented 1 year ago

Ah, I guess the bridge doesn't handle SIGTERM properly. This should fix it for the next version: 0753c70

luca-demma commented 1 year ago

Installed the new version, the problem persists

hensm commented 1 year ago

Can you test this build? fx_cast_bridge-0.3.0-x64.deb.zip

luca-demma commented 1 year ago

Tryed right now, same problem

hensm commented 1 year ago

Just tested it in a VM, it seems to fix it on my end compared to the released version which does hang. Possibly the package upgrade didn't work for you.

luca-demma commented 1 year ago

you're right, I had to uninstall and reinstall to make it work, apparently installing it ontop of the old one didn't work (maybe because they have the same version number)

TL;DR; it works now thanks 😀