hensm / fx_cast

Chromecast Web Sender SDK implementation for Firefox
https://hensm.github.io/fx_cast/
MIT License
1.89k stars 64 forks source link

Improve bridge error handling #275

Open hensm opened 1 year ago

hensm commented 1 year ago

Error handling for CastClient#connect is possibly incorrect and broken depending on how error events are emitted. Rejected promise is not handled by consumers and causes the bridge to crash which can under certain conditions result in error loops when the bridge is restarted.

https://github.com/hensm/fx_cast/blob/a9406fde110d59d102cb35440710b4bcb4a81ad1/bridge/src/bridge/components/cast/client.ts#L67-L70