search

hensm / fx_cast

Chromecast Web Sender SDK implementation for Firefox
https://hensm.github.io/fx_cast/
MIT License
1.89k stars 64 forks source link

Localization (0.0.5) #99

Closed hensm closed 4 years ago

hensm commented 4 years ago

@rimrul, @RAVMN, @Vistaus

Updated list if you want to provide new strings: https://github.com/hensm/fx_cast/blob/master/CONTRIBUTING.md#localizations

ThaDaVos commented 4 years ago

Where can we supply the translations?

ThaDaVos commented 4 years ago

Or even find them? :P

hensm commented 4 years ago

Locales are found at ext/src/_locales/: https://github.com/hensm/fx_cast/tree/master/ext/src/_locales

More info: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Internationalization#Providing_localized_strings_in__locales

ThaDaVos commented 4 years ago

According to this site: http://www.jsondiff.com/ there are 85 properties missing between both files, should I go over them all? Or completely redo the NL one based on the EN one?

hensm commented 4 years ago

It's okay, I already diffed them. They're listed in CONTRIBUTING at the link in the top comment.

Edit: They're also in order of their appearance in the messages.json file, so that should make it easier.

ThaDaVos commented 4 years ago

Here you go :D https://github.com/hensm/fx_cast/pull/100

PS: I did the whole thing

ThaDaVos commented 4 years ago

Can't you run the left over Locales through Google Translate and Bing Translate, compare the translations and which match use them?

hensm commented 4 years ago

I don't know how reliable machine translation would be. It may not translate idiomatically (which I can't check) and some of the messages have very little contextual info to assist. I could probably do Swedish, but anything else is lost on me.

I've used Microsoft's Terminology Collection in the past for simple things, but it's quite limited.

Side note, I found this translation tool that looks like it could make things much simpler: https://lusito.github.io/web-ext-translator/?gh=https://github.com/hensm/fx_cast/

ThaDaVos commented 4 years ago

Like I thought, there are tools for it, I've seen them in the past, even successfully used - you could always place a English Disclaimer at the bottom telling people that it's machinely translated and if there are mistakes they can make an issue about it, or supply better translations through a PR - this way, you won't be hold up on translations.

hensm commented 4 years ago

It might be worth exploring. Still not sure I'd want to mix human/machine translations in a single localization. I'm more comfortable just releasing with partial localizations.

Here's an example for Dutch: https://gist.github.com/hensm/a0c482720c20ecc36d343227bc718e6d

ThaDaVos commented 4 years ago

You can see it's translated by a machine sadly - it's to translated too direct

hensm commented 4 years ago

I suspected it wouldn't be great when I saw how different the results were compared to your translation.

I can schedule localizations better for future releases so I'm not waiting on anything. Also, the extension should be able to auto-update from the next release, so it's not a disaster if things aren't fully localized. Might have to bump to 1.0.0 for the versioning to indicate bridge compat for minor releases.

hensm commented 4 years ago

https://github.com/hensm/fx_cast/releases/tag/v0.0.5

Will catch German in the next release.