henszey / etcd-browser

A quick and easy way to view/edit basic keys in etcd.
http://henszey.github.io/etcd-browser/
MIT License
672 stars 232 forks source link

Allow to pass an url as a path parameter + prevent apps from crashing… #28

Closed samuel-soubeyran closed 7 years ago

samuel-soubeyran commented 7 years ago

Hello, Internally we needed to be able to bookmark with a connection to a given etcd. So we added a way to pass the url of an etcd server through a path parameter : http://192.168.99.100:8000/?url=http://xxx.xxx.net:2379

Also when running locally on docker it was making a request to /favicon.ico that caused an exception during the proxying. I added an on('error', function(){...}) to prevent the server to crash. This seems to be enough.

I think this would be helpful for others too and I hope this can make it upstream so that we don't maintain 2 versions. Let me know if you think there is a problem with this approach or if you'd like me to change the way it is currently implemented.

Thanks,

Sam