search

hentai-chan / hentai

Implements a wrapper class around nhentai's RESTful API.
https://www.hentai-chan.dev/projects/hentai
GNU General Public License v3.0
210 stars 21 forks source link

Fix rmdir after zip #133

Closed shikanime closed 3 years ago

shikanime commented 3 years ago

Unlink only work for file and not directory, since the destination output is always a directory.

hentai-chan commented 3 years ago

Could you please target hentai-chan:rec-hentai for your PR? Thanks!

shikanime commented 3 years ago

@hentai-chan CodeFactor doesn't seem to like the redefinition of zip', should we skip it or prefix it as_zip'? This may introduce some minor breaking changes but since the functionality was broken, it seems safe to change it by stealth 😛.