search

henyojess / generator-gulp-ng

This is a yeoman generator for an angularjs project that follows the Best Practice Recommendations for Angular App Structure. It takes advantage of the gulp build tool and makes use of bower and npm for dependency management.
137 stars 27 forks source link

Using with ionic framework, Module unavailable error #13

Open nolandubeau opened 10 years ago

nolandubeau commented 10 years ago

Hello, Given that the examples are extremely vanilla, I generated an app and attempted to add a third-party module such as the ionic framework. I followed the best practices and recommendation and added ionic using bower, and I now have an ionic folder in my bower_components folder. I then took a simple example from the ionic site and modified the appropriate files for routing as well as the app.js file. After running gulp and browsing the app I get a Module Unavailable error saying that the module ionic cannot be found - https://docs.angularjs.org/error/$injector/nomod?p0=ionic. I did a search within the compiled build/lib.js file and it appears that ionic has not been concatenated. Do you know why this is? It would be a great idea if you could provide some additional examples in the repo that demonstrate a more real world example of the recommendations and best practices. Currently the concepts are extremely solid, however I feel that the example the generator generates, despite demonstrating the best practices, is too simple and could almost be likened to the simplicity of the angular-seed project. Great work on the best practices. I'm really looking forward to implementing this. Thank you.

ee99ee commented 10 years ago

Did you add the files from bower_components to your index.html file? You have to actually include the files that bower installs

nolandubeau commented 10 years ago

Usually I do that but doesn't the gulp file of this generator actually do that automagically? That's what I derived from the documentation. I believe the gulp task called VendorJS and VendorCSS is supposed to do the concatenation into lib.js and that is what is included in index.html as opposed to having to include each vendor specific file.

On Monday, September 8, 2014, Chris Miller notifications@github.com wrote:

Did you add the files from bower_components to your index.html file? You have to actually include the files that bower installs

— Reply to this email directly or view it on GitHub https://github.com/henyojess/generator-gulp-ng/issues/13#issuecomment-54918705 .

Nolan Dubeau VP, Engineering Guardly

Sent from my Apple Newton

henyojess commented 9 years ago

hi @nolandubeau , did you find out what went wrong?

exp-gokul commented 9 years ago

Hi @nolandubeau , I am a ionic developer looking for feature module structure generator. Please reply whether you get it resolved, or is there any generator similar to my need to have a ionic + angular module generator. Please help me.