hepcat72 / node-red-contrib-life360

GNU General Public License v3.0
3 stars 4 forks source link

Catch fatal errors from server #9

Closed brianmay closed 2 years ago

brianmay commented 2 years ago

Fixes #8

Notes:

Possibly we should somehow distinguish different errors, and call node.debug(...) on the 5xx errors.

brianmay commented 2 years ago

I actually find looking for things in node-red documentation difficult. So this may not be correct.

I noticed this code, which I just changed also, I imagine this would result in a similar error loop. It probably should not be an error.

if (circles.length == 0) {
    throw new Error("No circles in your Life360.");
}
brianmay commented 2 years ago

Now testing... But not seeing any errors. Might have to somehow fake a server error if no real server errors.

hepcat72 commented 2 years ago

WRT auth errors, it's probably fine. There was a special character issue in one person's password awhile back where it may have been helpful to have that feedback (instead of it silently not working).

brianmay commented 2 years ago

I am going to close this in favour of #10. But if #10 has unexpected problems, feel free to reopen.