Makefile, Man-pages and some cleaning

hephaest0s / usbkill

« usbkill » is an anti-forensic kill-switch that waits for a change on your USB ports and then immediately shuts down your computer.

4.42k stars 508 forks source link

Makefile, Man-pages and some cleaning #68

Open MadsRC opened 9 years ago

MadsRC commented 9 years ago

A makefile for fast & easy install (and removal) of usbkill, it's settingsfile and 2 man pages explaining usbkill and it's settingsfile.

I also created a AUTHORS file with a list of everyone that was listed as cotnributors.

Last but not least, I trimmed the usbkill.py code so there's noi longer any unneeded trailing spaces.

hephaest0s commented 9 years ago

Thanks! But, I have two issues that prevent me from accepting this commit into master:

For an installer, I want to have `setup.py' install it as a script, as this is the conventional way for installing python programs. Also, I want to keep settings.ini in /etc/
You list authors in the authors file, but it is not clear to me that they want to be listed there (I wouldn't). I will ask them first if that is what they want, or they can notify me. You can list you and me there for now, and I will follow up on it.

ghost commented 9 years ago

Hello,

There is no problem to list me into the AUTHOR file but I think it's a bit useless as the commits are already speaking by themselves.

Regards, S

Sent from my iPhone

On 29 Jul 2015, at 11:58, Hephaestos notifications@github.com wrote:

Thanks! But, I have these issues that prevent me from accepting this commit into master:

For an installer, I want to have `setup.py' install it as a script, as this is the conventional way for installing python programs. Also, I want to keep settings.ini in /etc/

You list authors in the authors file, but it is not clear to me that they want to be listed there (I wouldn't). I will ask them first if that is what they want, or they can notify me. You can list you and me there for now, and I will follow up on it.

— Reply to this email directly or view it on GitHub.

MadsRC commented 9 years ago

Well, we're going to have to agree to disagree about the Makefile, but it's you're project. If you don't want it, I'll remove it. About the settings file, I'd still recommend having it in /usr/local/etc and then symlinking it in /etc. That way you get to reference /etc/usbkill/settings.ini in your code and be POSIX compliant. POSIX specifies that /etc is for system wide configuration and /usr/local/(etc...) is for local data specific to the host. It would also make the project more compliant towards the hier(7) page.

About the second, for me it's clear that people would want to be listed as contributors, as they already are listed, as @pwnsdx mentioned, in the commits and under "contributors on GitHub. I'll remove people, and have them enter it themselves.

I'll make a new commit later tonight.