search

heptio / aws-quickstart

AWS Kubernetes cluster via CloudFormation and kubeadm
Apache License 2.0
223 stars 134 forks source link

Fix CoreDNS test typo #166

Closed detiber closed 6 years ago

detiber commented 6 years ago

Resolves: https://github.com/heptio/aws-quickstart/issues/162

The CoreDNS setting was not taking effect due to a test that was failing for incorrect case.

detiber commented 6 years ago

Just finished validating these changes. The resulting cluster was indeed running coredns rather than kubedns:

~/src/heptio/aws-quickstart (fix_typo %)💰 kubectl get pods -n kube-system
NAME                                                 READY     STATUS    RESTARTS   AGE
calico-etcd-mmgh8                                    1/1       Running   0          6m
calico-kube-controllers-d669cc78f-g8xz2              1/1       Running   0          6m
calico-node-bkk99                                    2/2       Running   1          3m
calico-node-gl9d9                                    2/2       Running   1          6m
calico-node-xqtws                                    2/2       Running   0          4m
coredns-65dcdb4cf-ggqtq                              1/1       Running   0          6m
etcd-ip-10-0-6-175.ec2.internal                      1/1       Running   0          5m
kube-apiserver-ip-10-0-6-175.ec2.internal            1/1       Running   0          5m
kube-controller-manager-ip-10-0-6-175.ec2.internal   1/1       Running   0          5m
kube-proxy-nttv6                                     1/1       Running   0          6m
kube-proxy-tlpqh                                     1/1       Running   0          4m
kube-proxy-vjph6                                     1/1       Running   0          3m
kube-scheduler-ip-10-0-6-175.ec2.internal            1/1       Running   0          5m
kubernetes-dashboard-6658cd6658-525b6                1/1       Running   0          6m

The cluster also passed conformance: https://scanner.heptio.com/0df4939ca9b21a397de3772be1ce480a/diagnostics/