search

heptio / aws-quickstart

AWS Kubernetes cluster via CloudFormation and kubeadm
Apache License 2.0
223 stars 134 forks source link

Set allocate-node-cidrs to false #219

Closed vincepri closed 5 years ago

vincepri commented 5 years ago

This commits fixes an error in the k8s controller manager that showed “Couldn't reconcile node routes: error listing routes: unable to find route table for AWS cluster” when controller manager is started with --cloud-provider=aws.

Signed-off-by: Vince Prignano vince@vincepri.com

Fixes #214

chuckha commented 5 years ago

The default is already false

https://github.com/kubernetes/kubernetes/blob/master/cmd/controller-manager/app/options/kubecloudshared.go#L76

Does this get set to true at some point otherwise?

vincepri commented 5 years ago

This is the only thing I could find https://github.com/kubernetes/kubernetes/blob/3fe21e5433988b9512e74f42bf07a036be84a263/cmd/kubeadm/app/phases/controlplane/manifests.go#L316

On Sep 28, 2018, at 10:03 AM, Chuck Ha notifications@github.com wrote:

The default is already false

https://github.com/kubernetes/kubernetes/blob/master/cmd/controller-manager/app/options/kubecloudshared.go#L76 https://github.com/kubernetes/kubernetes/blob/master/cmd/controller-manager/app/options/kubecloudshared.go#L76 Does this get set to true at some point otherwise?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/heptio/aws-quickstart/pull/219#issuecomment-425501593, or mute the thread https://github.com/notifications/unsubscribe-auth/AC-U_-xLe8gvPsNdCpV39DTWZHozdZt9ks5uflZXgaJpZM4W9zmu.

chuckha commented 5 years ago

/lgtm

davidedal commented 5 years ago

Hi, I have exactly this error using AWS with Ark. How should I apply the heptio:master to my Kubernetes? Ricompile everything or there's already an updated version?

Thanks