heptio / aws-quickstart

AWS Kubernetes cluster via CloudFormation and kubeadm
Apache License 2.0
223 stars 134 forks source link

BastionHost IP is hardcoded #237

Open wiquan opened 5 years ago

wiquan commented 5 years ago

What steps did you take and what happened: [A clear and concise description of what the bug is.]

Tried to create a cluster on a new 10.127.0.0 VPC. I found the bastion host IP is hardcoded here: https://github.com/heptio/aws-quickstart/blob/master/templates/kubernetes-cluster-with-new-vpc.template#L663

What did you expect to happen: Expected the bastion host to have an IP allocated from my public subnet, not a hardcoded one shown above.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

wiquan commented 5 years ago

After-the-fact I found this documented in the PDF. Nonwithstanding, this should be part of the template IMHO.