search

heptio / kube-conformance

Kuberenetes e2e conformance container
Apache License 2.0
31 stars 27 forks source link

Log client/server versions before starting tests. #6

Closed mml closed 7 years ago

mml commented 7 years ago

I had thought e2e.test outputted this, but it does not. kubetest does, and I think once this image is generated as a release artifact, we should just switch to using kubetest.

timothysc commented 7 years ago

@mml Why not put this into upstream also? We can cherry pick onto 1.8 and pull downstream until upstream produces a e2e container that is not kubekins.

Also, sonobuoy already reports this https://github.com/heptio/sonobuoy/blob/master/docs/img/snapshot-00-overview.png in the serverversion.json file.

mml commented 7 years ago

I can find a place for it upstream, but in the meantime, I'd like this to start working even with 1.7. Putting it here for the moment ensures it works with all test images. I can leave a TODO: Take this out when... comment if you like?

As for already reporting this, we don't report the version of the e2e.test binary. That's what we're asking reviewers to compare.

mml commented 7 years ago

^ @timothysc

mml commented 7 years ago

kubernetes/kubernetes#53502