search

herb-mc / extra_enchants

Source and buildscripts for Herb's Extra Enchants. Curseforge link: https://www.curseforge.com/minecraft/mc-mods/herbs-extra-enchants.
MIT License
4 stars 4 forks source link

Loot tables using the minecraft:enchant_randomly function are still using disabled enchantments #12

Open elhertz opened 2 years ago

elhertz commented 2 years ago

Hello. I've noticed that my disabled enchantments were still appearing on loot chests then decided to do some investigation. The enchant_randomly mcfunction doesn't care about disabled enchantments at all. After I noticed that I was still getting enchanted books and items with disabled enchantments I had to manually modify all the loot tables from minecraft and mods. Is there a way to fix this?

herb-mc commented 2 years ago

I'll look into a way to fix this, but nothing can really be done on your end besides manually editing everything. I had thought I fixed this issue with the latest release, but I'll have to look into it a bit further now.

elhertz commented 2 years ago

Maybe this is a different issue, albeit related, but I've noticed that vanilla mobs are spawning with enchantments as well. I wish I could disable that. Edit: thanks for taking my request in consideration!

elhertz commented 2 years ago

I think spellbound's dev implemented something to prevent disabled enchantments from appearing on loot https://github.com/Tigereye504/spellbound

elhertz commented 2 years ago

I've found this while searching stuff on discord. I don't know anything about java but this might be helpful to solve this issue discord (screenshot taken from the fabric discord server)