search

herb-mc / extra_enchants

Source and buildscripts for Herb's Extra Enchants. Curseforge link: https://www.curseforge.com/minecraft/mc-mods/herbs-extra-enchants.
MIT License
4 stars 4 forks source link

Crash on startup caused by conflicting enchants with another mod #5

Closed 3th3 closed 3 years ago

3th3 commented 3 years ago

I won't log the crash report. There is no need to, here is the important snippet. @ModifyConstant conflict. Skipping extra_enchants.mixins.json:LivingEntityMixin->@ModifyConstant::applyReflex(I)I with priority 1000, already redirected by sihywtcamc.mixins.json:shield.LivingEntityBlockingMixin->@ModifyConstant::instantlyBlock(I)I with priority 1000

Seems simple enough, reflex is conflicting with instantblock. The conflicting mod is https://www.curseforge.com/minecraft/mc-mods/sihywtcamc#c37. I don't think instantlyBlock is an enchant, however. Its supposed to be a new trait to shields in general.

charlyb01 commented 3 years ago

The reflex enchantment modifies the same constant value as I do (in my mod) to block instantly. I guess we can solve this compatibility issue by setting different priority levels for our changes but I'm not sure about it as I never did this. I'll check that a bit later and tell you

herb-mc commented 3 years ago

I'll look into this on my end as well, I will see if I can do away with the ModifyConstant entirely as to avoid this issue in the future

herb-mc commented 3 years ago

I have addressed this particular compatibility issue in the latest alpha release. I will let this issue remain open until I publish an official release.

charlyb01 commented 3 years ago

Good, I'll do the same change to my mod I guess so that mine won't have the issue with another mod doing the same. Thanks

3th3 commented 3 years ago

I have addressed this particular compatibility issue in the latest alpha release. I will let this issue remain open until I publish an official release.

Thanks bunches! Happy to know I can use both of these mods at once again when the update releases

charlyb01 commented 3 years ago

Fixed in the lastest version of my mod too. It works fine using both of these mods now. Reference: commit