search

herbertmilhomme / PokemonUnity

Pokémon Unity Documentations/Wiki
https://herbertmilhomme.github.io/PokemonUnity/
BSD 3-Clause "New" or "Revised" License
31 stars 8 forks source link

Refactored PokemonDatabase & moved hardcoded pokemon data to .json files #1

Closed Sedatb23 closed 6 years ago

Sedatb23 commented 6 years ago

Status

Description

Testing

Concerns, notes, etc.

Related issues

Related PRs

herbertmilhomme commented 6 years ago

@Sedatb23 I had to backtrack your pull request to the original commit right before you did the merge on your end. There were some conflicts with the code, and some parts ended up getting deleted and removed. Also, i opted to abstain from the json files, because the thought of mass editing frightened me (having to edit each file one by one, did not help me to feel comfortable with the concept). Though i did keep the class files because it'll make for great implementations with Online/Multiplayer functionalities.