Source code leak

[zhangyandong]

This issue seems to have arisen in version 2.3.1 https://github.com/herberttn/bytenode-webpack-plugin/issues/15

[zhangyandong]

This issue only occurs on Windows

[jjeff]

Your link doesn't seem to work for some reason. You're saying that this issue has re-emerged on Windows in the current version (2.3.1)?

I wrote a source code leak test for the electron-bytenode-example project, but I don't think I've updated that since 2.3.1. I'll update that soon and see if I can confirm. It would probably be a good idea to have source code leak tests as part of the tests in this repo too.

[jjeff]

I just added some automated testing to the electron-bytenode-example project and I cannot replicate this bug for Windows, Linux, or Mac… at least for an Electron build.

I can't speak for @herberttn, but I'm guessing he's going to need more detail about your issue.

[herberttn]

I can't speak for @herberttn, but I'm guessing he's going to need more detail about your issue.

Absolutely. Right now there are no details, at all. I'll need a reproduction repository to try and fix it. @zhangyandong can you make one?

I just added some automated testing to the electron-bytenode-example project and I cannot replicate this bug for Windows, Linux, or Mac… at least for an Electron build.

@jjeff There is a leak test here, added when I fixed #15

[herberttn]

@zhangyandong does this still happen? If so, can you create a reproduction repo?

[SamHoque]

Still seems to happen on a fresh clone of bytenode electron. I tried running the test, the test passes with asar mode on and off. but I can see the string in the code.