herbsjs / buchu

Use Cases - Uniform, auditable and secure use case library

Other

24 stars 22 forks source link

Add request to auditTrail #66

Closed VictorTBX closed 2 years ago

VictorTBX commented 2 years ago

Co-authored-by: Cassio Oliveira Silva cassiointw1993@gmail.com Co-authored-by: Bruno Cavalcante Razera brunocrazera@gmail.com Co-authored-by: Sander Iwase sanderiw@gmail.com Co-authored-by: Matheus Vicente matheus.vicente10@outlook.com.br Co-authored-by: Diogo Oliveira diogooliveira792@gmail.com Co-authored-by: Julia Dibo juliadibo@gmail.com

VictorTBX commented 2 years ago

56

codecov[bot] commented 2 years ago

Codecov Report

Merging #66 (73283c0) into master (2d29f00) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   97.50%   97.53%   +0.03%     
==========================================
  Files           6        6              
  Lines         240      243       +3     
==========================================
+ Hits          234      237       +3     
  Misses          6        6

Impacted Files	Coverage Δ
src/usecase.js	`96.29% <100.00%> (+0.21%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4bd47c3...73283c0. Read the comment docs.

dalssoft commented 2 years ago

Can we have more tests for when a request field is a entity type?

VictorTBX commented 2 years ago

Can we have more tests for when a request field is a entity type?

@dalssoft do you think that one test with the request being an entity type is enough? Do you see any other scenario? The string serialization should work for any kind of object.

dalssoft commented 2 years ago

there are uc out there with entities as request parameters.

should work

exactly. let's make sure.

also, unusual and not recommended but could happen: request: { entity: { entity

VictorTBX commented 2 years ago

@dalssoft changes made! Could you check if are these enough and correct, please?

dalssoft commented 2 years ago

after all the required changes are submitted, pls change the doc as well: https://github.com/herbsjs/herbsjs.github.io/issues/104

we will merge both PRs together.

VictorTBX commented 2 years ago

https://github.com/herbsjs/herbsjs.github.io/pull/108

DOC PR

jhomarolo commented 2 years ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: