Feature: entity computed property - Githubissues

herbsjs / gotu

Entities - Create your Entity and enjoy an elegant validation and serialization

Other

11 stars 19 forks source link

Feature: entity computed property #69

Open VictorTBX opened 1 year ago

VictorTBX commented 1 year ago

https://github.com/herbsjs/gotu/issues/68

This is still a draft, I'd like of understand if I'm on the right path before continuing.

Proposed Changes

Add feature for defining function properties, updating them when properties are set

Author/Contributor

[ ] If documentation is needed for this change, has that been included in this pull request -> Not yet
[ ] Remember to check if code coverage decrease, if so, please implement the necessary tests -> Some unit testes need to be rewriten due to the use of strictly deep-equal. I'll do this when I'm sure of the next steps.

Reviewing Maintainer

[ ] Label as breaking if this is a large fundamental change
[ ] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

dalssoft commented 1 year ago

great PR!

from https://github.com/herbsjs/gotu/issues/68#issuecomment-1366214765

I started developing this feature, but I'm stucked with two problems

with no tests I think it's hard to affirm it's only two problems... In order to improve this PR, even for a POC, tests are mandatory to understand the proposal and the implementation