search

herbsjs / herbs-cli

Herbs CLI
https://herbsjs.org/
MIT License
30 stars 31 forks source link

`herbs new` fails when git is not installed #110

Closed willsoares closed 2 years ago

willsoares commented 2 years ago

Describe the bug While starting a new project with herbs new command, the process fails when trying to git init a repository, rather than informing the user that git isn't installed

To Reproduce

  1. Have a machine without git installed
  2. Run herbs new
  3. Select 'Do you want to initialize a Git repository? Yes'

image

italojs commented 2 years ago

I'm sure it's a bug because you really don't have the git installed into your machine, but I agree it's not a great development experience. What do you think about checking if the git exists before we try to run the git? so, if the git isn't we could just show a message instead an error

italojs commented 2 years ago

if I help you, could you fix it for us, please?

BritoDoug commented 2 years ago

I will take a look on that problem

herbsjs-robot commented 2 years ago

:tada: This issue has been resolved in version 2.7.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: