italojs commented 2 years ago

I didn't open an issue for this because I fixed it when I got the problem.

basically, we don't must create migrations for mongo, so, I just avoid it when we have a mongo config in the project.

codecov[bot] commented 2 years ago

Codecov Report

Merging #118 (89c4dec) into main (8b65e4e) will decrease coverage by 0.13%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   71.83%   71.69%   -0.14%     
==========================================
  Files          21       21              
  Lines         316      318       +2     
==========================================
+ Hits          227      228       +1     
- Misses         89       90       +1

Impacted Files	Coverage Δ
...rators/src/infra/database/migrations/migrations.js	`20.00% <75.00%> (+1.81%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44052b1...89c4dec. Read the comment docs.

italojs commented 2 years ago

WTF, we don't have 75% test coverage into this project

jhomarolo commented 2 years ago

:tada: This PR is included in version 2.4.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

herbsjs / herbs-cli

fix: ignore migration for mongo database #118

Codecov Report