herbsjs / herbs-cli

Herbs CLI
https://herbsjs.org/
MIT License
30 stars 31 forks source link

fix: herbs graphql layer dont have inputs types #119

Closed italojs closed 2 years ago

italojs commented 2 years ago

I didn't open an issue for this because I fixed it when I got the problem.

The problem: when we works with nested items like this

const Party =
        entity('Party', {
          id: id(Number),
          address: field(String),
          hour: field(Date),
          attendees: field([Attendee]),
          items: field([Item])
        })

we must to create an input type for the graphql layer

so basically, I'm generating an input type for all entities

codecov[bot] commented 2 years ago

Codecov Report

Merging #119 (5f8a4d7) into main (8b65e4e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files          21       21           
  Lines         316      316           
=======================================
  Hits          227      227           
  Misses         89       89           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44052b1...5f8a4d7. Read the comment docs.

jhomarolo commented 2 years ago

:tada: This PR is included in version 2.4.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: