search

herbsjs / herbs-cli

Herbs CLI
https://herbsjs.org/
MIT License
30 stars 31 forks source link

Herbs2GQL with Herbarium - Update code generation #124

Closed dalssoft closed 2 years ago

dalssoft commented 2 years ago

Dependency: https://github.com/herbsjs/herbs2gql/issues/38

When the above issue is ready it will be necessary to change the current infrastructure generated automatically for GraphQL to a new one (much simpler one).

The generated file should leave space for customization using metadata or the inclusion of custom mutations, queries and types.

PedroMarquesFr commented 2 years ago

I'm working on it.

PedroMarquesFr commented 2 years ago

Hi guys, on the cli docs one of the steps are to specify the entity, but when i run it to check how the changes are working it doesn't appear, I can't find any related code to this step at the repo besides at the readme. How can I call it? @dalssoft @italojs @jhomarolo Image

dalssoft commented 2 years ago

on the cli docs one of the steps are to specify the entity, but when i run it to check how the changes are working it doesn't appear

this feature has been deprecated and is no longer valid. the doc should be updated

jhomarolo commented 2 years ago

@PedroMarquesFr I agree with David.

It seems this is not an issue anymore. We should update the doc removing this part.

PedroMarquesFr commented 2 years ago

True, so there are no way to generate code using entities with cli right? I think the PR is ready to review herbsjs/herbs-cli#143

dalssoft commented 2 years ago

@PedroMarquesFr the ideia of this issue is to substitute the current files on infra\api\graphql (mutations.js, queries.js, types.js) for a simple call with herbarium as described in https://github.com/herbsjs/herbs2gql/issues/38

PedroMarquesFr commented 2 years ago

@dalssoft So the files on infra\api\graphql (mutations.js, queries.js, types.js) would not exist anymore and those functions would go to the index.js file with herbs2gql(herbarium), right? Thats what I understood

dalssoft commented 2 years ago

@PedroMarquesFr mutations.js, queries.js, types.js has already been moved to herbs2gql (https://github.com/herbsjs/herbs2gql/issues/38 / https://github.com/herbsjs/herbs2gql/pull/54). now you just need to refactory to remove this files on the cli template

PedroMarquesFr commented 2 years ago

@dalssoft can you check if its covering all point correctly?

PedroMarquesFr commented 2 years ago

@dalssoft I fixed coverage, can you take a look?

PedroMarquesFr commented 2 years ago

@dalssoft @jhomarolo I had send the fixes can you check it?

herbsjs-robot commented 2 years ago

:tada: This issue has been resolved in version 2.14.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: