Herbs project must to born with Dockerfile

herbsjs / herbs-cli

Herbs CLI

https://herbsjs.org/

MIT License

30 stars 30 forks source link

Herbs project must to born with Dockerfile #13

Open italojs opened 3 years ago

italojs commented 3 years ago

I was thinking the herbs-cli could have an option to create the project with an setup config, example


>herbs new
>Do you need a setup config file? [y/N] y
- Make file
- Dockerfile
- Dockerfile + docker-compose
- container engine1
- container engine2

ssmaciel commented 2 years ago

When you say 'container engine1' and 'container engine2', do you mean to generate the Kubernetes manifest files?

Example:

 >herbs new
 >Do you need a setup config file? [y/N] y
 - Make file
 - Dockerfile
 - Dockerfile + docker-compose
 - Kubernetes - Pod
 - Kubernetes - Pod + Service

italojs commented 2 years ago

it could be an option too

jhomarolo commented 2 years ago

@ssmaciel can you take this issue?

dalssoft commented 2 years ago

I'm not convinced we should have this kind of boilerplate on herbs cli given it has no direct relationship with Herbs capabilities

jhomarolo commented 2 years ago

I thought the idea of the cli was to evolve to a place close to a real application.

Since many applications today already use docker and/or kubernetes, the application to come with a preconfigured file would make sense in my opinion.

maikmb commented 2 years ago

I agree with @jhomarolo! HERBS are for real life and many applications today run in containers. As an option in the CLI, I think it's an interesting improvement.