mtperesvx commented 2 years ago

@jhomarolo and @dalssoft. Would you please check this change?

dalssoft commented 2 years ago

is it related to what issue / PR?

codecov[bot] commented 2 years ago

Codecov Report

Merging #140 (ca88f0f) into main (5cba87c) will increase coverage by 0.28%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   81.23%   81.51%   +0.28%     
==========================================
  Files          22       23       +1     
  Lines         373      395      +22     
==========================================
+ Hits          303      322      +19     
- Misses         70       73       +3

Impacted Files	Coverage Δ
src/commands/new.js	`81.39% <0.00%> (ø)`
example-entities/user.js	`100.00% <0.00%> (ø)`
src/generators/src/infra/git.js	`84.21% <0.00%> (ø)`
...rators/src/infra/database/migrations/migrations.js	`92.10% <0.00%> (+0.43%)`	:arrow_up:
src/generators/check-version.js	`85.71% <0.00%> (+2.38%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb8db24...ca88f0f. Read the comment docs.

mtperesvx commented 2 years ago

@dalssoft There is no open issue for this feature. It's just to send an entity to generate Routes to use the ID field as a reference in the endpoint dynamically. PR: https://github.com/herbsjs/herbs2rest/pull/34#pullrequestreview-1023286654

herbsjs-robot commented 2 years ago

:tada: This PR is included in version 2.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

herbsjs / herbs-cli

feat(index.ejs): include entity property in controllers list #140

Codecov Report