search

herbsjs / herbs-cli

Herbs CLI
https://herbsjs.org/
MIT License
29 stars 30 forks source link

feat: new herbs2gql syntax #143

Closed PedroMarquesFr closed 2 years ago

PedroMarquesFr commented 2 years ago

Fixes #124

Proposed Changes

  1. New simpler graphql syntax based on new herbs2gql update

Readiness Checklist

Author/Contributor

Reviewing Maintainer

codecov[bot] commented 2 years ago

Codecov Report

Merging #143 (fd893df) into main (f6a8539) will increase coverage by 1.69%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   85.47%   87.17%   +1.69%     
==========================================
  Files          24       25       +1     
  Lines         420      421       +1     
==========================================
+ Hits          359      367       +8     
+ Misses         61       54       -7
Impacted Files Coverage Δ
src/generators/src/infra/api/graphql.js 100.00% <ø> (ø)
src/generators/src/packagejson.js 100.00% <ø> (ø)
src/commands/spec.js 50.00% <0.00%> (-1.12%) :arrow_down:
src/generators/src/readme.js 100.00% <0.00%> (ø)
src/generators/src/infra/shell/permissions.js 100.00% <0.00%> (ø)
src/commands/shell.js 90.00% <0.00%> (+12.72%) :arrow_up:
src/generators/utils.js 96.29% <0.00%> (+15.52%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.

PedroMarquesFr commented 2 years ago

Codecov Report

Merging #143 (8c3d14b) into main (ca88f0f) will decrease coverage by 0.14%. The diff coverage is 82.14%.

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   81.51%   81.37%   -0.15%     
==========================================
  Files          23       23              
  Lines         395      392       -3     
==========================================
- Hits          322      319       -3     
  Misses         73       73

Impacted Files Coverage Δ
src/commands/new.js 81.39% <ø> (ø)
src/generators/src/infra/api/graphql.js 100.00% <ø> (ø)
src/generators/src/packagejson.js 100.00% <ø> (ø)
...rators/src/infra/database/migrations/migrations.js 92.10% <71.42%> (ø)
src/generators/src/infra/git.js 84.21% <84.21%> (ø)
src/generators/check-version.js 85.71% <100.00%> (ø)
Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d68b18...8c3d14b. Read the comment docs.

I think it drops because I removed 3 files, not sure if this is a problem.

dalssoft commented 2 years ago

Things that I missed on this new version:

dalssoft commented 2 years ago

To make it more clear (https://github.com/herbsjs/herbs-cli/pull/143#issuecomment-1182472057) here is the missing points:

PedroMarquesFr commented 2 years ago

To make it more clear (#143 (comment)) here is the missing points:

Thanks

PedroMarquesFr commented 2 years ago

@dalssoft can you check if its covering all point correctly?

dalssoft commented 2 years ago

@PedroMarquesFr looks good to merge, however the CI is not passing due to decrease in code coverage. can you check it?

italojs commented 2 years ago

what means the custom folder? why is it named custom?

herbsjs-robot commented 2 years ago

:tada: This PR is included in version 2.14.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: