search

herbsjs / herbs-cli

Herbs CLI
https://herbsjs.org/
MIT License
29 stars 30 forks source link

feat(new dynamic readme): new dynamic readme for herbs cli projects #146

Closed othonvv closed 2 years ago

othonvv commented 2 years ago

Creating a dynamic readme for all herbs cli projects and changing it content to a domain driven approach.

Fix: #87

othonvv commented 2 years ago

@dalssoft @jhomarolo hi guys, this is the PR for the dynamic readme generator.

othonvv commented 2 years ago

@dalssoft changes made.

dalssoft commented 2 years ago

@othonvv the code is ready to merge but it seems this PR is breaking CI. can you check it?

othonvv commented 2 years ago

@dalssoft I made two commits trying a new approach for the test, but for some reason CI did not run yet.

jhomarolo commented 2 years ago

@othonvv try to keep your test file like this: https://github.com/othonvv/herbs-cli/blob/dynamic-readme/src/tests/packagejson.test.js

It's not necessary to link to npm since is already linked inside the other file

othonvv commented 2 years ago

@jhomarolo ok, fixed.

herbsjs-robot commented 2 years ago

:tada: This PR is included in version 2.10.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jhomarolo commented 2 years ago

Congrats @othonvv!