search

herbsjs / herbs-cli

Herbs CLI
https://herbsjs.org/
MIT License
29 stars 30 forks source link

We need to improve the tests #151

Open endersoncosta opened 2 years ago

endersoncosta commented 2 years ago

Today the tests are too superficial, seeing this, we need to improve this to test the generated project, not only test the command as we do today...

What you think?

jhomarolo commented 2 years ago

I agree 100% with you, I think the cli structurally needs two things:

1 - A considerable refactor, it's full of code smells 2 - A test coverage that actually gives us a guarantee of safe change

italojs commented 2 years ago

I think a refactor could be more interesting at this moment, increasing the test coverage will generate more work in the future with the current code

dalssoft commented 2 years ago

I would suggest a massive refactoring with some structural changes:

  1. have a plugin architecture
  2. move the generators, templates, etc to the plugins
  3. move most of the tests to the plugins