Describe the bug

When I try to run to run unit tests, I get this error at terminal:

To reproduce

Run npm run test at terminal

codecov[bot] commented 1 year ago

Codecov Report

Merging #176 (e8f29e3) into main (9458969) will increase coverage by 0.85%. The diff coverage is 25.34%.

:exclamation: Current head e8f29e3 differs from pull request most recent head 787ea51. Consider uploading reports for the commit 787ea51 to get more accurate results

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   67.28%   68.14%   +0.85%     
==========================================
  Files          27       27              
  Lines         593      609      +16     
==========================================
+ Hits          399      415      +16     
  Misses        194      194

Impacted Files	Coverage Δ
src/generators/src/packagejson.js	`100.00% <ø> (ø)`
src/commands/assist.js	`5.00% <5.00%> (ø)`
src/commands/spec.js	`63.33% <55.31%> (+13.33%)`	:arrow_up:
src/helpers/toolbox.js	`65.00% <65.00%> (ø)`
src/commands/new.js	`83.67% <85.71%> (ø)`
src/commands/update.js	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

dalssoft commented 1 year ago

@tadvortx did you check if this didn't change the behavior? It seems it would change it.

tadvortx commented 1 year ago

@dalssoft, yes I checked and tested:

Created new project after this change;
ran all tests;
ran herbs assist;
ran all tests again;

after this we committed this change

vitorgamer58 commented 1 year ago

When I run herbs spec in my telegram-bot with tests in /test/ folder, the herbs-cli doesn't find any test, and return an error: TypeError: usecasesGroup[groupName] is not iterable

With our changes, when I run herbs spec in my telegram-bot I get: Specs finished with no errors! 🤩

I passed these changes to my branch, where I'm developing the spec's ability to receive a custom path, and when I run herbs spec I get:

 (spec)
   🗸  Deve responder com os dados da ação se ela existir (scenario)
   🗸  Deve responder com erro se a ação for inválida (scenario)
   🗸  Deve calcular o preço justo (scenario)
   🗸  Deve retornar erro se o ticker da ação for inválido (scenario)

  Specs finished with no errors! 🤩

So it's working fine.

herbsjs-robot commented 1 year ago

:tada: This PR is included in version 2.18.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

herbsjs / herbs-cli

fix bug in running test #176

Describe the bug

To reproduce

Codecov Report