herbsjs / herbs-cli

Herbs CLI
https://herbsjs.org/
MIT License
29 stars 30 forks source link

Always create the gitignore file (fixes 186) #187

Closed gustavobigardi closed 1 year ago

gustavobigardi commented 1 year ago

Fixes #186

This PR changes the .gitignore file to be generated always, even when not initializing a new git repository. Also, it fixes the test of the herbs spec command, failing due to the random success messages from aloe.

Proposed Changes

  1. Always generate a .gitignore file, event if not initializing a git repository
  2. Fixing the herbs spec test, since aloe is generating a random success message and the test was failing

Readiness Checklist

Author/Contributor

Reviewing Maintainer

codecov[bot] commented 1 year ago

Codecov Report

Merging #187 (d50fbb8) into main (f76e785) will increase coverage by 0.93%. The diff coverage is 100.00%.

:exclamation: Current head d50fbb8 differs from pull request most recent head e103ff7. Consider uploading reports for the commit e103ff7 to get more accurate results

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   67.81%   68.75%   +0.93%     
==========================================
  Files          27       28       +1     
  Lines         612      560      -52     
==========================================
- Hits          415      385      -30     
+ Misses        197      175      -22     
Impacted Files Coverage Δ
src/generators/index.js 100.00% <ø> (ø)
src/generators/src/infra/git.js 83.33% <ø> (-0.88%) :arrow_down:
src/commands/spec.js 100.00% <100.00%> (+36.66%) :arrow_up:
src/generators/src/gitignore.js 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more