herbsjs / herbs

A domain-first framework. Code your domain and your infrastructure will follow
https://herbsjs.org/
MIT License
427 stars 14 forks source link

New labels for issues and pull requests #8

Closed jhomarolo closed 2 years ago

jhomarolo commented 2 years ago

I'm thinking about the labels on issues and pull requests and would like to hear from you before implementing them.

Suggestions for issues and pull requests:

What do you think? Missed something? Overlabeling?

italojs commented 2 years ago

I think:

-1 good first issue is not necessary -2 I dont get the diference between help wanted and question -3 working would be WIP that github undestand as Work in progress -4 i think would be nice to have tha labels effort:easy effort:medium effort:hard

italojs commented 2 years ago

i think we need a ready-to-do or something to say that issue is waiting for someone to make the implementation

jhomarolo commented 2 years ago

-1 good first issue is not necessary

Agree

-2 I dont get the diference between help wanted and question

Question is someone asked something, help wanted is when a issue is opened for a long time and no one knows the awnser

-3 working would be WIP that github undestand as Work in progress

Agree

-4 i think would be nice to have tha labels effort:easy effort:medium effort:hard

Effort is a subjective thing, I don't know if it would actually be effective as each person can judge complexity in a totally different way.

italojs commented 2 years ago

About the effort, hmmm, but after a great discussion we know the effort size approximation, if this is "small", "medium" or "big" effort.

jhomarolo commented 2 years ago

I'll implement these labels this week.

@italojs about the effort, let's discuss inside the herbs monthly meeting, ok?

jhomarolo commented 2 years ago

Labels are now implemented: https://github.com/herbsjs/herbs/labels

I'll replicate to others repositories now