herbsjs / herbs2gql

Create a GraphQL endpoint based on Entities and Use Cases
MIT License
14 stars 21 forks source link

Include Default Resolver Class #20

Closed maikvortx closed 3 years ago

maikvortx commented 3 years ago

Proposed Changes

  1. Inclusion of the Default Resolver class
  2. Inclusion of the documentation to readme

Readiness Checklist

Author/Contributor

Reviewing Maintainer

codecov[bot] commented 3 years ago

Codecov Report

Merging #20 (1977c6a) into master (7b4a855) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 1977c6a differs from pull request most recent head 5ff0e55. Consider uploading reports for the commit 5ff0e55 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##            master       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        12    +2     
  Lines          138       156   +18     
=========================================
+ Hits           138       156   +18     
Impacted Files Coverage Δ
src/herbs2gql.js 100.00% <ø> (ø)
src/args2request.js 100.00% <100.00%> (ø)
src/defaultResolver.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b4a855...5ff0e55. Read the comment docs.

maikvortx commented 3 years ago

Hello @dalssoft! I updated the documentation with your suggestions.

dalssoft commented 3 years ago

@maikvortx next step would be to update to-do list.

maikvortx commented 3 years ago

Hey @dalssoft!

Will the new version of the herbs2gql npm package be released automatically after the CI is executed?

dalssoft commented 3 years ago

@maikmb not really but I've just published the new version.

maikvortx commented 3 years ago

Thanks! I will update TodoList!

jhomarolo commented 3 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: