herbsjs / herbs2gql

Create a GraphQL endpoint based on Entities and Use Cases

MIT License

14 stars 21 forks source link

Fix: array of entities as field of another entity #50

Closed Vx-Nico closed 2 years ago

Vx-Nico commented 2 years ago

Fixes #106

Adds support to use an array of entities as a field inside another entity

Proposed Changes

Fix the entityFieldType2gql function to accept array of entities

Readiness Checklist

Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[x] Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

[ ] Label as breaking if this is a large fundamental change
[ ] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

codecov[bot] commented 2 years ago

Codecov Report

Merging #50 (b803290) into master (7761dc0) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head b803290 differs from pull request most recent head 1dac7b4. Consider uploading reports for the commit 1dac7b4 to get more accurate results

@@            Coverage Diff            @@
##            master       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          173       173           
=========================================
  Hits           173       173

Impacted Files	Coverage Δ
src/helpers/gqlConverters.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47eabd4...1dac7b4. Read the comment docs.

jhomarolo commented 2 years ago

:tada: This PR is included in version 2.1.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: