herbsjs / herbs2gql

Create a GraphQL endpoint based on Entities and Use Cases

MIT License

14 stars 21 forks source link

Feat: Herbarium - Use it to create mutations, queries and types #54

Closed PedroMarquesFr closed 2 years ago

PedroMarquesFr commented 2 years ago

Created herbarium support to herbs2gql

Fixes #38

Proposed Changes

Created a new import called herbarium2gql file
Added herbarium library
New test
New documentation

Readiness Checklist

Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[x] Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

[ ] Label as breaking if this is a large fundamental change
[ ] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

italojs commented 2 years ago

awesome PR @PedroMarquesFr , thank you very much! could you add a session in our documentation please?

codecov[bot] commented 2 years ago

Codecov Report

Merging #54 (9cf5cc5) into master (4f6e74e) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        14    +1     
  Lines          173       192   +19     
=========================================
+ Hits           173       192   +19

Impacted Files	Coverage Δ
src/herbs2gql.js	`100.00% <ø> (ø)`
src/herbarium2gql.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83b167b...9cf5cc5. Read the comment docs.

dalssoft commented 2 years ago

@PedroMarquesFr thank you for this PR. It is on the right path!

dalssoft commented 2 years ago

when I look at the To Do List project, there it is possible to find custom mutations and queries - here

in this format with herbarium, how would this scenario of custom mutations and queries look like?

PedroMarquesFr commented 2 years ago

when I look at the To Do List project, there it is possible to find custom mutations and queries - here

in this format with herbarium, how would this scenario of custom mutations and queries look like?

As mutations, queries and types array struture didnt change it would work the same way, using push method, but all in the index file and not on each individual file. Example using quoted To Do List project:

PedroMarquesFr commented 2 years ago

I think now the CI is working, can you run it again please @jhomarolo ?

dalssoft commented 2 years ago

@PedroMarquesFr the PR is read to merge but it seems the test coverage has dropped. Can you check it?

jhomarolo-vortx commented 2 years ago

It seems that have some "it.only" inside the test suite. @PedroMarquesFr could you please remove them?

herbsjs-robot commented 2 years ago

:tada: This PR is included in version 2.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: