herbsjs / herbs2knex

Create repositories using Knex to retrieve and store Entities
Other
7 stars 13 forks source link

Include FindAll method #13

Closed maikmb closed 3 years ago

maikmb commented 3 years ago

Proposed Changes

  1. Include findAll method to Repository Base

Readiness Checklist

Author/Contributor

Reviewing Maintainer

codecov[bot] commented 3 years ago

Codecov Report

Merging #13 (fd83f01) into master (9cf311a) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head fd83f01 differs from pull request most recent head 3a25bce. Consider uploading reports for the commit 3a25bce to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         4    +1     
  Lines          117       136   +19     
=========================================
+ Hits           117       136   +19     
Impacted Files Coverage Δ
src/helpers/isEmpty.js 100.00% <100.00%> (ø)
src/repository.js 100.00% <100.00%> (ø)
src/dataMapper.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9cf311a...3a25bce. Read the comment docs.

maikvortx commented 3 years ago

Hi @dalssoft , chages done!

jhomarolo commented 3 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: