herbsjs / herbs2knex

Create repositories using Knex to retrieve and store Entities

Other

7 stars 13 forks source link

feat(first): add first method feature #28

Closed jhomarolo closed 3 years ago

jhomarolo commented 3 years ago

Fixes #26

Proposed Changes

Add first method feature
Partial extraction of find method logic for reuse in first method (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields)
Update suma dependency

Readiness Checklist

Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[x] Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

[ ] Label as breaking if this is a large fundamental change
[x] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

codecov[bot] commented 3 years ago

Codecov Report

Merging #28 (e6db241) into master (c2ed159) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          132       141    +9     
=========================================
+ Hits           132       141    +9

Impacted Files	Coverage Δ
src/repository.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2ed159...e6db241. Read the comment docs.

jhomarolo commented 3 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: