herbsjs / herbs2knex

Create repositories using Knex to retrieve and store Entities

Other

7 stars 13 forks source link

Add mysql tests #33

Closed jhomarolo closed 2 years ago

jhomarolo commented 3 years ago

Fixes #32

Proposed Changes

add mysql tests
fix mysql update

Readiness Checklist

Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[ ] Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

[ ] Label as breaking if this is a large fundamental change
[ ] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

codecov[bot] commented 3 years ago

Codecov Report

Merging #33 (96408f4) into master (61081b9) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          141       143    +2     
=========================================
+ Hits           141       143    +2

Impacted Files	Coverage Δ
src/repository.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21cd1b5...96408f4. Read the comment docs.

jhomarolo commented 2 years ago

:tada: This PR is included in version 1.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: