search

herbsjs / herbs2rest

Create a REST API based on HerbsJS
MIT License
2 stars 13 forks source link

Add peerDependencies #31

Closed mtperesvx closed 2 years ago

mtperesvx commented 2 years ago

Adding "express" to peerDependencies.

jhomarolo commented 2 years ago

@mtperesvx could you please update the dependency as well to finish this PR?

Please also use 'git cz' instead 'git commit'.

codecov[bot] commented 2 years ago

Codecov Report

Merging #31 (2cfcda9) into main (34e825c) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          106       106           
=========================================
  Hits           106       106

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d904ab2...2cfcda9. Read the comment docs.

mtperesvx commented 2 years ago

@jhomarolo done.

jhomarolo commented 2 years ago

It seems the update was not reflected

Please use https://www.npmjs.com/package/npm-check-updates

Run this in root folder: npx npm-check-updates and update dependencies please.

mtperesvx commented 2 years ago

@jhomarolo would you please check now?

jhomarolo commented 2 years ago

:tada: This PR is included in version 2.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: